Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: invoke wrapper hook manually #84220

Closed

Conversation

svalaskevicius
Copy link
Contributor

@svalaskevicius svalaskevicius commented Apr 3, 2020

This is less of a PR, more of an issue - why was gappsWrapperArgsHook not invoked automatically? this used to work a while back and stopped at some point..

noticed as the file open dialog has stopped working again.. ie crashes the program

@FRidh
Copy link
Member

FRidh commented Apr 5, 2020

because buildCommand is used. That shouldn't be used.

@svalaskevicius
Copy link
Contributor Author

Right. It did work fine a while back though - has anything changed?

Also quite a few more places are using it: https://github.com/NixOS/nixpkgs/search?q=buildCommand&type=

@worldofpeace
Copy link
Contributor

fixed in 96f52cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants