Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2.gnome_icon_theme: 2.91.93 -> 3.12.0 #84230

Merged
merged 8 commits into from Apr 6, 2020
Merged

gnome2.gnome_icon_theme: 2.91.93 -> 3.12.0 #84230

merged 8 commits into from Apr 6, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 4, 2020

Motivation for this change
  • gnome2.gnome_icon_theme: 2.91.93 -> 3.12.0
  • gnome2.gnome_icon_theme: use pname and version
  • gnome2.gnome_icon_theme: add meta attributes
  • gnome2.gnome_icon_theme: change platform to unix
  • gnome2.gnome_icon_theme: minor layout change
  • gnome2.gnome_icon_theme: do not drop icon theme cache
  • treewide: rename gnome2.gnome_icon_theme package to use dashes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from proteansec and rasendubi April 4, 2020 02:37
rasendubi
rasendubi approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me 👍

@jtojnar
Copy link
Contributor

jtojnar commented Apr 5, 2020

Ugh, do these things still work? GNOME panel has changed its API at least three times so I doubt Alarm clock will do anything.

I would just remove as much of gnome2 attribute set as possible.

@romildo
Copy link
Contributor Author

romildo commented Apr 6, 2020

I am more interested in gnome-icon-theme because there are several other icon themes that still inherits from it.

I intend to add dependencies for icon themes (at least the ones I maintain) according to the inheritance declared in their index.theme.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2020

Could you also move it out of gnome2 attribute set, then? I intend to get rid of it this cycle.

@romildo
Copy link
Contributor Author

romildo commented Apr 6, 2020

Could you also move it out of gnome2 attribute set, then? I intend to get rid of it this cycle.

Done.

@ofborg ofborg bot requested a review from rasendubi April 6, 2020 01:24
@romildo romildo merged commit 9908785 into NixOS:master Apr 6, 2020
@romildo romildo deleted the upd.gnome-icon-theme branch April 6, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@proteansec proteansec Awaiting requested review from proteansec

@rasendubi rasendubi Awaiting requested review from rasendubi

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @jtojnar @rasendubi