Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages.create-elm-app: init at 4.2.4 #84276

Merged
merged 1 commit into from Apr 10, 2020
Merged

elmPackages.create-elm-app: init at 4.2.4 #84276

merged 1 commit into from Apr 10, 2020

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Apr 4, 2020 •
edited

I was asked about packinging this in past but since it seemed difficult and I'm personally not a huge fan of generators which just hide complexity I didn't do it at the time. Now I need this for new job so I thought I might upstream it for the benefit of others.

Unfortunately this package also requires some nasty hacks has tons of dependencies which causes some bloat.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @domenkozar

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages.create-elm-app

@turboMaCk
Copy link
Member Author

cc @domenkozar this is ready for review

domenkozar
domenkozar reviewed Apr 6, 2020
View reviewed changes
pkgs/development/compilers/elm/default.nix Outdated
preRebuild = ''
# This should not be needed (thanks to binwrap* being nooped) but for some reason it still needs to be done
# in case of just this package
sed 's/\"install\".*/\"install\":\"echo no-op\",/g' --in-place node_modules/elmi-to-json/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you need patchBinwrap [ elm elmi-to-json ] or it doesn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm compiler doesn't use binwrap package but own custom script in install.js.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was too sloppy checking the context.

I believe I tried to use patchBinwrap function but it didn't work. I'm afraid something might have changed in binwrap which broke our script but let me double check that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domenkozar i got it resolved. I would swear this wasn't working before but most likely I just did some stupid mistake - probably I was applying patch for elm instead of elmi-to-json or something.

@domenkozar domenkozar merged commit a0f0bcd into NixOS:master Apr 10, 2020
@turboMaCk turboMaCk deleted the create-elm-app branch February 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @domenkozar