Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] python3Packages.pulumi-* init #84258

Closed
wants to merge 7 commits into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 4, 2020

Motivation for this change

Initializing basic pulumi python resources for devops.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

costrouc commented Apr 4, 2020

Result of nixpkgs-review pr 84258 1

46 package marked as broken and skipped:
  • digitalbitbox
  • iterm2
  • linuxPackages_4_4.evdi
  • linuxPackages_hardkernel_4_14.bcc
  • linuxPackages_hardkernel_4_14.bpftrace
  • linuxPackages_hardkernel_4_14.can-isotp
  • linuxPackages_hardkernel_4_14.chipsec
  • linuxPackages_hardkernel_4_14.digimend
  • linuxPackages_hardkernel_4_14.evdi
  • linuxPackages_hardkernel_4_14.mba6x_bl
  • linuxPackages_hardkernel_4_14.nvidia_x11
  • linuxPackages_hardkernel_4_14.nvidia_x11_legacy390
  • linuxPackages_hardkernel_4_14.nvidiabl
  • linuxPackages_hardkernel_4_14.prl-tools
  • linuxPackages_hardkernel_4_14.rtl8814au
  • linuxPackages_hardkernel_4_14.rtl8821au
  • linuxPackages_hardkernel_4_14.rtl8821ce
  • linuxPackages_hardkernel_4_14.rtlwifi_new
  • linuxPackages_hardkernel_4_14.v4l2loopback
  • newlibCross
  • nix-linter
  • octave-jit
  • php72Packages-unit.php_excel
  • php72Packages-unit.v8
  • php72Packages-unit.v8js
  • php72Packages.php_excel
  • php72Packages.v8
  • php72Packages.v8js
  • php73Packages-unit.php_excel
  • php73Packages-unit.v8
  • php73Packages.php_excel
  • php73Packages.v8
  • php74Packages-unit.couchbase
  • php74Packages-unit.pcs
  • php74Packages-unit.php_excel
  • php74Packages-unit.v8
  • php74Packages.couchbase
  • php74Packages.php_excel
  • php74Packages.v8
  • python27Packages.caffe
  • python27Packages.flitBuildHook
  • python37Packages.notify
  • python37Packages.pyblock
  • python38Packages.nixpart
  • python38Packages.notify
  • python38Packages.pyblock
14 package built:
  • python37Packages.pulumi
  • python37Packages.pulumi-aws
  • python37Packages.pulumi-azure
  • python37Packages.pulumi-digitalocean
  • python37Packages.pulumi-gcp
  • python37Packages.pulumi-kubernetes
  • python37Packages.pulumi-random
  • python38Packages.pulumi
  • python38Packages.pulumi-aws
  • python38Packages.pulumi-azure
  • python38Packages.pulumi-digitalocean
  • python38Packages.pulumi-gcp
  • python38Packages.pulumi-kubernetes
  • python38Packages.pulumi-random

@costrouc
Copy link
Member Author

costrouc commented Apr 4, 2020

Not sure why checks are failing? Also I am debugging the usage of these python packages to make sure they work properly. Currently run into "error: failed to load plugin /home..."

@costrouc costrouc changed the title python3Packages.pulumi-* init [WIP] python3Packages.pulumi-* init Apr 4, 2020
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like checks are failing because none of the packages have meta.platforms set and are then trying to evaluate on aarch64, which pulumi doesn't appear to support. See:

platforms = builtins.attrNames data.pulumiPkgs;

@stale
Copy link

stale bot commented Oct 2, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:01
@mudrii
Copy link
Contributor

mudrii commented Nov 27, 2020

@costrouc is any update on this package?
I would be happy to co-maintain the packages

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@teto
Copy link
Member

teto commented Jan 26, 2022

@costrouc @mudrii any chance either of you resume this ? I am interested in this as well. I can either review or eventually complete if that's not too much work.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 26, 2022
@teto
Copy link
Member

teto commented Mar 6, 2022

sry I pushed to your branch that was not my intention. I opened an update for the packages I am interested in at #163062

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022
@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants