Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nat: fix multiple destination ports with loopback #81597

Merged
merged 1 commit into from Mar 4, 2020

Conversation

thatsmydoing
Copy link
Contributor

Motivation for this change

When using the nat module to forward multiple ports in an entry, applying the firewall fails because the port format is wrong. For the --dport argument, port ranges are of the form from:to but for the --destination argument it's from-to.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/modules/services/networking/nat.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 4, 2020

@GrahamcOfBorg test nat

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests are passing.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 4, 2020

Thank you for contributing!

@rnhmjoj rnhmjoj merged commit 481a4e9 into NixOS:master Mar 4, 2020
@thatsmydoing thatsmydoing deleted the multiport-nat branch March 10, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants