Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corerad: 0.2.1 -> 0.2.2 #81665

Merged
merged 1 commit into from Mar 10, 2020
Merged

corerad: 0.2.1 -> 0.2.2 #81665

merged 1 commit into from Mar 10, 2020

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Mar 4, 2020

Motivation for this change

New beta release of CoreRAD, which also supports linking in the current version and tag timestamp.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Built and tested on NixOS:

[matt@routnerr-2:~/src/nixpkgs]$ nix-build -A corerad
these derivations will be built:
  /nix/store/71axxsdxc3jqiz9bh87pa3i5p9c12qhd-corerad-0.2.2.drv
building '/nix/store/71axxsdxc3jqiz9bh87pa3i5p9c12qhd-corerad-0.2.2.drv'...
[...]

[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad -h
CoreRAD v0.2.2 BETA (2020-03-03)
flags:
  -c string
        path to configuration file (default "corerad.toml")
  -init
        write out a default configuration file to "corerad.toml" and exit

[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad -init

[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad
2020/03/03 19:22:16 CoreRAD v0.2.2 BETA (2020-03-03) starting with configuration file "corerad.toml"
2020/03/03 19:22:16 eth0: advertise is false, skipping initialization
2020/03/03 19:22:16 starting HTTP debug listener on "localhost:9430": prometheus: false, pprof: false
^C2020/03/03 19:22:18 received interrupt, shutting down

The latest git tag's timestamp is hardcoded at the moment, but it uses the git tag's timestamp:

$ git log -1 --format=%ct v0.2.2
1583280117

I haven't found an easy way to incorporate the above shell command into the package build, but would appreciate suggestions!

/cc @jonringer @kalbasit @danderson

@mdlayher
Copy link
Member Author

mdlayher commented Mar 4, 2020

@GrahamcOfBorg test corerad

@ofborg ofborg bot requested a review from kalbasit March 4, 2020 00:51
@mdlayher
Copy link
Member Author

mdlayher commented Mar 9, 2020

Hey folks, any concerns here? Thanks!

jonringer
jonringer approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

[5 built, 51 copied (481.7 MiB), 115.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81665
1 package built:
corerad

@jonringer jonringer merged commit 13964b0 into NixOS:master Mar 10, 2020
@mdlayher mdlayher deleted the mdl-corerad-bump branch March 10, 2020 03:21
@mdlayher
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdlayher @jonringer