Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
base: 5dee76e9b203
Choose a base ref
...
head repository: NixOS/ofborg
compare: ea4b7f8aab39
Choose a head ref
  • 4 commits
  • 20 files changed
  • 2 contributors

Commits on Feb 21, 2020

  1. Update to current nixpkgs-unstable

    This required the introduction of an overlay file since ofBorg still
    requires openssl 1.0.2. Updating to newer version of openssl also
    requires updating the amqp library which requires some more involved
    changes.
    
    The php code is only updated to php 7.2 and not 7.3 (the default in
    nixpkgs) since there seem to been a few syntax changes that aren't yet
    compatible with composer2nix.
    
    In previous versions of the rust infrastructure within nixpkgs we would
    have been able to override all crates during the invocation of the
    target crate. That `override` feature was removed as it caused a huge
    eval overhead for larger projects. We did end up with (n^2)
    instantiations of dependencies since they were being overriden on every
    invocation of every dependency on every level further down the chain.
    The current understanding is that the build tooling that each project is
    using (e.g.  crate2nix, crate2nix, …) that is driving the actual build
    could easily reintroduce that feature without the overhead.
    
    pin to php72
    andir committed Feb 21, 2020
    Copy the full SHA
    41687fe View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    31205e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. fix new linting issues

    andir committed Feb 22, 2020
    Copy the full SHA
    e3e32bc View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Merge pull request #436 from andir/update-nixpkgs

    Update to current nixpkgs-unstable
    grahamc committed Mar 4, 2020
    Copy the full SHA
    ea4b7f8 View commit details
    Browse the repository at this point in the history