Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] libfido2: change dependency from libressl to openssl #81614

Merged
merged 1 commit into from Mar 6, 2020
Merged

[20.03] libfido2: change dependency from libressl to openssl #81614

merged 1 commit into from Mar 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Mar 3, 2020

Motivation for this change

libressl does not enable EdDSA functionality in libfido2
see Yubico/libfido2#144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
libfido2: change dependency from libressl to openssl
271af49 
libressl does not enable EdDSA functionality in libfido2
see Yubico/libfido2#144

(cherry picked from commit 4135584798e428a98d0ded9dab337673bd048f05)
@prusnak prusnak changed the title libfido2: change dependency from libressl to openssl [20.03] libfido2: change dependency from libressl to openssl Mar 3, 2020
@ofborg ofborg bot requested a review from dtzWill March 3, 2020 12:17
@FRidh FRidh merged commit 4707311 into NixOS:release-20.03 Mar 6, 2020
@prusnak prusnak deleted the libfido2-20.03 branch March 6, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @FRidh