Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfido2: change dependency from libressl to openssl #81613

Merged
merged 2 commits into from Mar 11, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Mar 3, 2020

Motivation for this change

libressl does not enable EdDSA functionality in libfido2
see Yubico/libfido2#144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

libressl does not enable EdDSA functionality in libfido2
see Yubico/libfido2#144
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've honestly always wondered what was meant by the phrasing of their documentation re:libressl vs openssl, apologies as it seems I went the wrong way 🐈 . Glad the documentation makes this clearer now, regardless.

Can't test eddsa but since it can't work without moving away from libressl this seems safe as it can hardly regress in that capacity.

I've previously tried both libressl/openssl and both worked for my usage. 👍.

@dtzWill dtzWill merged commit d847032 into NixOS:master Mar 11, 2020
@marsam
Copy link
Contributor

marsam commented Mar 11, 2020

This should have gone into staging

@prusnak prusnak deleted the libfido2 branch March 11, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants