Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gom: 0.3.3 → 0.4 #81616

Merged
merged 3 commits into from Mar 3, 2020
Merged

gom: 0.3.3 → 0.4 #81616

merged 3 commits into from Mar 3, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 3, 2020

Motivation for this change

Update gom & fix folks & add docs for folks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hedning March 3, 2020 12:47
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 3, 2020

Just noticed gom is also being updated in 3.35 branch but it should be fine to merge this to unstable now. All gom reverse dependencies build.

@hedning
Copy link
Contributor

hedning commented Mar 3, 2020

Yeah, much better to merge this here. I've tried to keep regular updates out, but something needed gom-4.

@hedning hedning mentioned this pull request Mar 3, 2020
Merged
@jtojnar jtojnar mentioned this pull request Mar 3, 2020
Closed
10 tasks
worldofpeace
worldofpeace approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit c5590dd into NixOS:master Mar 3, 2020
@jtojnar jtojnar deleted the gom-update branch March 3, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @hedning @worldofpeace