Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbound: 1.9.5 -> 1.10.0 #81605

Merged
merged 1 commit into from Mar 14, 2020
Merged

Unbound: 1.9.5 -> 1.10.0 #81605

merged 1 commit into from Mar 14, 2020

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Mar 3, 2020 •
edited

Motivation for this change

Version bump.

https://github.com/NLnetLabs/unbound/blob/release-1.10.0/doc/Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, fpletz and ehmry March 3, 2020 10:08
ehmry
ehmry approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@ehmry ehmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #81312.

@FRidh
Copy link
Member

FRidh commented Mar 6, 2020

This should target staging.

@FRidh FRidh added this to WIP in Staging via automation Mar 6, 2020
@FRidh FRidh changed the base branch from master to staging March 14, 2020 22:04
@ofborg ofborg bot requested a review from ehmry March 14, 2020 22:14
@alyssais alyssais merged commit 2410dbb into NixOS:staging Mar 14, 2020
Staging automation moved this from WIP to Done Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @FRidh @ehmry @alyssais