Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 4.2.1 -> 4.3.0 #81730

Merged
merged 2 commits into from Mar 4, 2020
Merged

radare2: 4.2.1 -> 4.3.0 #81730

merged 2 commits into from Mar 4, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 4, 2020 •
edited by lsix

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from makefu and 7c6f434c March 4, 2020 15:41
lsix
lsix requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I have built and tested the update. Everything seems fine. nix-review is mostly happy (except for unityhub which is also broken in master due to invalid hash).

You should probably quote the homepage url in meta.homepage (c.f. RFC45 ).

Except for this minor update request, ok for me.

@lsix lsix self-requested a review March 4, 2020 17:17
lsix
lsix approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to me.

Thanks!

@Mic92 Mic92 merged commit fb6f2d1 into NixOS:master Mar 4, 2020
@Mic92 Mic92 deleted the radare2 branch March 4, 2020 17:27
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 4, 2020
@Mic92 @dtzWill
radare2: 4.2.1 -> 4.3.0 (NixOS#81730)
579a2cd 
(cherry picked from commit fb6f2d1)
Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Aug 7, 2020
@Mic92
radare2: 4.2.1 -> 4.3.0 (NixOS#81730)
3097539 
(cherry picked from commit fb6f2d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@makefu makefu Awaiting requested review from makefu

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @lsix