howard-hinnant-date: allow access to zoneinfo #81594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situtation where, if
/usr/share/zoneinfo
wasinaccessible/didn't otherwise exist,
howard-hinnant-date
woulddownload and drop a
~/Downloads/tzdata
directory containing sometimezone information from IANA [1]. To avoid this, we make use of the
tzdata
'szoneinfo
, preventing the dropping of random directories andfiles.
[1] https://data.iana.org/time-zones/releases/tzdata2019c.tar.gz
Motivation for this change
This was discovered after a brief conversation on IRC with @lovesegfault who noticed
~/Downloads/tzdata
was being created by... something. It was traced back to the Waybar from nixpkgs -- I could not reproduce with a Waybar built from source on my non-NixOS system, butnix-shell -p waybar --run waybar
reproduced the issue perfectly.Because howard-hinnant-date hardcodes the default timezone path to
/usr/share/zoneinfo
, we have to patch it to point to thezoneinfo
directory oftzdata
(and obviously enable the use of this "system tz db" to avoid downloading one).Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Sorry to the unrelated reviewers requested -- I had originally touched
Waybar
, but that was unnecessary.