Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adminer: init at 4.7.6 #81717

Merged
merged 1 commit into from Mar 4, 2020
Merged

adminer: init at 4.7.6 #81717

merged 1 commit into from Mar 4, 2020

Conversation

haskelious
Copy link
Contributor

Motivation for this change

Creation of the Adminer package that can then be used in an nginx with php (or other web server) instance to publish the service. This is a web-based database admin tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should not go to phpPackages as well.

pkgs/servers/adminer/default.nix Outdated Show resolved Hide resolved
@jtojnar
Copy link
Contributor

jtojnar commented Mar 4, 2020

Do you use any extra themes or plug-ins with this? I am currently managing them manually but want to port that over to Nix as well.

@haskelious
Copy link
Contributor Author

@jtojnar no I do not use any extra functionality, just the basic adminer. However feel free to suggest changes to package to include extra plugins or themes.

@jtojnar jtojnar merged commit 88e2389 into NixOS:master Mar 4, 2020
@haskelious haskelious deleted the fix/adminer-create branch March 4, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haskelious @jtojnar