Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.monosat: Fix builds broken by #81562 #81638

Merged
merged 1 commit into from Mar 3, 2020
Merged

python3Packages.monosat: Fix builds broken by #81562 #81638

merged 1 commit into from Mar 3, 2020

Conversation

acairncross
Copy link
Contributor

Motivation for this change

See #81562
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@acairncross
python3Packages.monosat: Fix hash
aa7fced 
PR NixOS#81562 inadvertently broke these builds
@jonringer
Copy link
Contributor

hmm, lol, #81643

@jonringer
Copy link
Contributor

fetchpatch is special in that it does normalization before adding the patch to the store, never use nix-prefetch-url with it, or if you do, ensure to "invalidate" it and ensure you get the right hash.

jonringer
jonringer approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81638
3 package built:
monosat python37Packages.monosat python38Packages.monosat

@jonringer jonringer merged commit 3db82f6 into NixOS:master Mar 3, 2020
@acairncross acairncross mentioned this pull request Mar 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acairncross @jonringer