Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdmapsharing: init at 3.9.10 #81619

Merged
merged 1 commit into from Apr 6, 2021
Merged

libdmapsharing: init at 3.9.10 #81619

merged 1 commit into from Apr 6, 2021

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 3, 2020 •
edited

Currently failing to build: https://gitlab.gnome.org/GNOME/libdmapsharing/issues/11

Motivation for this change

Library that implements the DMAP family of protocols

https://gitlab.gnome.org/GNOME/libdmapsharing

One of the unpackaged backends for grilo-plugins library. The version in Nixpkgs depends on older version at the moment but GNOME 3.36 will support this one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to Would be nice to have in GNOME 3.36 Mar 4, 2020
@worldofpeace worldofpeace added this to In Progress in GNOME Apr 10, 2020
@worldofpeace worldofpeace removed this from Would be nice to have in GNOME 3.36 Apr 10, 2020
@stale
Copy link

stale bot commented Dec 29, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2020
@SuperSandro2000
Copy link
Member

@jtojnar please fix the eval eror.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@jtojnar jtojnar marked this pull request as ready for review March 20, 2021 00:35
@jtojnar jtojnar changed the title libdmapsharing: init at 3.9.7 libdmapsharing: init at 3.9.10 Mar 20, 2021
@ofborg ofborg bot requested a review from dasj19 March 20, 2021 00:42
@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from amaxine April 6, 2021 00:45
@SuperSandro2000 SuperSandro2000 merged commit d51de7d into NixOS:master Apr 6, 2021
GNOME automation moved this from In Progress to Done Apr 6, 2021
@jtojnar jtojnar deleted the libdmapsharing branch May 18, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti fogti left review comments

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@dasj19 dasj19 Awaiting requested review from dasj19

@amaxine amaxine Awaiting requested review from amaxine

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @SuperSandro2000 @fogti