Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix folks package #81645

Closed
wants to merge 2 commits into from
Closed

fix folks package #81645

wants to merge 2 commits into from

Conversation

andir
Copy link
Member

@andir andir commented Mar 3, 2020

Motivation for this change

This fixes the hydra build failure: https://hydra.nixos.org/build/113851386/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jtojnar and hedning March 3, 2020 19:28
@jtojnar
Copy link
Contributor

jtojnar commented Mar 3, 2020

See also #81616

@andir
Copy link
Member Author

andir commented Mar 3, 2020

Oh, that didn't show up as a good hit when searching for "folks".

@worldofpeace
Copy link
Contributor

I think I'd prefer to merge @jtojnar PR, it fixes up a few more things at once.

@jtojnar jtojnar closed this Mar 3, 2020
@worldofpeace
Copy link
Contributor

Oh, that didn't show up as a good hit when searching for "folks".

Yeah, it was not initially apparent. But I guess it was discovered whilst updating gom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callahad callahad Awaiting requested review from callahad

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @jtojnar @worldofpeace