Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catt: 0.10.3 -> 0.11.0 #81707

Merged
merged 1 commit into from May 8, 2020
Merged

catt: 0.10.3 -> 0.11.0 #81707

merged 1 commit into from May 8, 2020

Conversation

luke-clifton
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@luke-clifton
Copy link
Contributor Author

luke-clifton commented Mar 9, 2020 via email

Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected. hash format should be fine, since it's already used in common-updater-scripts (see #78913)

@marsam marsam merged commit b10bcf8 into NixOS:master May 8, 2020
@marsam
Copy link
Contributor

marsam commented May 8, 2020

sorry for the late response. Thanks, I didn't know sri was already supported by fetchurl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants