Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uvcdynctrl: fix udev files #81693

Merged
merged 1 commit into from Apr 8, 2020
Merged

uvcdynctrl: fix udev files #81693

merged 1 commit into from Apr 8, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I tried adding uvcdynctrl to services.udev.packages and it (rightfully) exploded complaining about broken paths in the rules. This fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from puffnfresh March 4, 2020 06:49
@lovesegfault lovesegfault deleted the uvcdynctrl-udev branch April 7, 2020 07:32
@lovesegfault lovesegfault restored the uvcdynctrl-udev branch April 7, 2020 07:35
@lovesegfault lovesegfault reopened this Apr 7, 2020
@lovesegfault
Copy link
Member Author

cc. @worldofpeace

@worldofpeace
Copy link
Contributor

nixos apr 2020, signs of life. I guess we still have worldofpeace 🤣

This LGTM 👍

@worldofpeace worldofpeace merged commit d9a0569 into NixOS:master Apr 8, 2020
@lovesegfault lovesegfault deleted the uvcdynctrl-udev branch April 8, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @worldofpeace @grahamc