Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow: fix #77626 #81633

Merged
merged 2 commits into from Mar 5, 2020
Merged

Tensorflow: fix #77626 #81633

merged 2 commits into from Mar 5, 2020

Conversation

andir
Copy link
Member

@andir andir commented Mar 3, 2020

Motivation for this change

This fixes #77626 by using an older Bazel version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

I thought we added back bazel 1 to fix tensorflow?

Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bazel 1 was not old enough after all.
shaking fist against the sky screaming Tensorfloooooow

This allows us to get rid of the compatibility hacks that we had to add
(tf-1.15-bazel-1.0.patch) and also fixes NixOS#77626.
@andir
Copy link
Member Author

andir commented Mar 4, 2020

Removed the maintainers line. As I am not really a tensorflow maintainer just someone that actually tries to unbreak it (once) I didn't add myself there.

I am hopeful that we can move on to newer Bazel versions once we finally get everything properly to TF2.. Whenever that is...

@andir andir merged commit 82b54d4 into NixOS:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants