Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam_ssh_agent_auth: Honour services.openssh.authorizedKeysFiles #81661

Merged
merged 1 commit into from Nov 24, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Mar 3, 2020

If a system administrator has explicitly configured key locations this should be taken into account by sudo.

Note This needs some things before merging:
- A test - see comment

  • A release note with big fat red warning stickers ⚠️ 🚨
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member Author

I gave up on writing a test after battling segmentation faults in sudo that I could not reproduce outside of the VM...

@stale
Copy link

stale bot commented Nov 14, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 14, 2020
@SuperSandro2000
Copy link
Member

If you get around fixing the segfaulting test feel free to reopen the discussion.

@adisbladis adisbladis reopened this Nov 24, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 24, 2020
@adisbladis
Copy link
Member Author

@SuperSandro2000 I don't think the segfaulting tests are super important to fix. It was a while ago since I looked at this but iirc I concluded that it was an upstream bug in sudo and had nothing to do with the PAM module, and it was absolutely unrelated to anything this PR touches.

If a system administrator has explicitly configured key locations this
should be taken into account by `sudo`.
@adisbladis adisbladis merged commit 302df2a into NixOS:master Nov 24, 2020
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Everything other than what is proposed here is unexpected to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants