Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclone: 1.50.2 -> 1.51.0 #81678

Merged
merged 1 commit into from Mar 5, 2020
Merged

rclone: 1.50.2 -> 1.51.0 #81678

merged 1 commit into from Mar 5, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Update rclone to latest stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from danielfullmer and ehmry March 4, 2020 03:16
@colemickens
Copy link
Member Author 

[cole@xeep:~/code/nixpkgs-rclone]$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 26 (delta 15), reused 15 (delta 13), pack-reused 2
Unpacking objects: 100% (26/26), 45.80 KiB | 976.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   29150a28c08..7aa084521b3  master     -> refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-58ea5f3a177b0eb50497f60be136c94c1d70c2c3/nixpkgs 7aa084521b34efd71e9b17728f605011a1565a36
Preparing worktree (detached HEAD 7aa084521b3)
Updating files: 100% (21112/21112), done.
HEAD is now at 7aa084521b3 Merge pull request #81694 from r-ryantm/auto-update/liblouis
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-58ea5f3a177b0eb50497f60be136c94c1d70c2c3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 58ea5f3a177b0eb50497f60be136c94c1d70c2c3
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-58ea5f3a177b0eb50497f60be136c94c1d70c2c3/nixpkgs -qaP --xml --out-path --show-trace --meta
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'override'
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'overrideDerivation'
2 package updated:
git-annex-remote-rclone rclone (1.50.2 → 1.51.0)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-58ea5f3a177b0eb50497f60be136c94c1d70c2c3/build.nix
[5 built, 23 copied (535.9 MiB), 135.2 MiB DL]
2 package built:
gitAndTools.git-annex-remote-rclone rclone

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-58ea5f3a177b0eb50497f60be136c94c1d70c2c3/shell.nix
these paths will be fetched (1.51 MiB download, 8.27 MiB unpacked):
  /nix/store/6wf86wppdpy6hwlv9c7dickvs547n2bv-bash-interactive-4.4-p23-dev
  /nix/store/apah3qkxv6s05rj3rvlliw7gjdfwmi1a-bash-interactive-4.4-p23-doc
  /nix/store/cqdbhg2xv6mql8j80ybk05cz3m9fgi4b-bash-interactive-4.4-p23-man
  /nix/store/f5lqh5am3a6cbxq25yan13cqv32qcmf1-bash-interactive-4.4-p23
  /nix/store/g4n1li9q6cg70mg81xlrhb1z4rcrs7ba-bash-interactive-4.4-p23-info
  /nix/store/xf23gh81m2x0pb2cld494rfdll4afb2w-readline-7.0p5
copying path '/nix/store/apah3qkxv6s05rj3rvlliw7gjdfwmi1a-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/g4n1li9q6cg70mg81xlrhb1z4rcrs7ba-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/cqdbhg2xv6mql8j80ybk05cz3m9fgi4b-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/xf23gh81m2x0pb2cld494rfdll4afb2w-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/f5lqh5am3a6cbxq25yan13cqv32qcmf1-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/6wf86wppdpy6hwlv9c7dickvs547n2bv-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

danielfullmer
danielfullmer approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See also #79062 which does this update and also adds some autocomplete files for bash/zsh. However, that PR hasn't yet been updated with a requested fix for cross-compilation.

@marsam marsam merged commit 9b99706 into NixOS:master Mar 5, 2020
@marsam
Copy link
Contributor

marsam commented Mar 5, 2020

that PR hasn't yet been updated with a requested fix for cross-compilation

Sorry about that, I totally forgot about that PR. I'm gonna update it later today

@colemickens colemickens deleted the nixpkgs-rclone branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colemickens @marsam @danielfullmer