Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.stem: 1.7.1 -> 1.8.0 #81679

Merged
merged 1 commit into from Mar 7, 2020
Merged

pythonPackages.stem: 1.7.1 -> 1.8.0 #81679

merged 1 commit into from Mar 7, 2020

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Mar 4, 2020 •
edited

Motivation for this change

This updates the python package stem to its latest stable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Phreedom March 4, 2020 03:11
@colemickens
Copy link
Member Author 

[cole@xeep:~/code/nixpkgs-stem]$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs 7aa084521b34efd71e9b17728f605011a1565a36
Preparing worktree (detached HEAD 7aa084521b3)
Updating files: 100% (21112/21112), done.
HEAD is now at 7aa084521b3 Merge pull request #81694 from r-ryantm/auto-update/liblouis
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit f539a47dabe6fd614179ee7df12d596bdab1dff9
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs -qaP --xml --out-path --show-trace --meta
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'override'
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'overrideDerivation'
7 package updated:
nyx onioncircuits python2.7-stem (1.7.1 → 1.8.0) python3.7-stem (1.7.1 → 1.8.0) python3.8-stem (1.7.1 → 1.8.0) qutebrowser tor-exporter

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/build.nix
[9 built, 312 copied (1488.4 MiB), 328.1 MiB DL]
7 package built:
nyx onioncircuits prometheus-tor-exporter python27Packages.stem python37Packages.stem python38Packages.stem qutebrowser

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/shell.nix

@marsam
Copy link
Contributor

marsam commented Mar 7, 2020

@GrahamcOfBorg build qutebrowser

@marsam marsam merged commit 9d44f2f into NixOS:master Mar 7, 2020
@marsam
Copy link
Contributor

marsam commented Mar 7, 2020

Thanks!

ryneeverett added a commit to ryneeverett/nixpkgs that referenced this pull request Apr 25, 2020
@ryneeverett
pythonPackages.stem: remove marked as broken
e349f5c 
A third attempt after NixOS#85642 which I hadn't recognized as a backport
of NixOS#81679.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

(cherry picked from commit 618cdd2)
@ryneeverett ryneeverett mentioned this pull request Apr 25, 2020
Merged
10 tasks
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@ryneeverett @stigok
pythonPackages.stem: remove marked as broken
622b024 
A third attempt after NixOS#85642 which I hadn't recognized as a backport
of NixOS#81679.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

(cherry picked from commit 618cdd2)
@colemickens colemickens deleted the nixpkgs-stem branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @marsam