Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p4: init at 2017.3.1601999 #79339

Closed
wants to merge 2 commits into from
Closed

p4: init at 2017.3.1601999 #79339

wants to merge 2 commits into from

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Feb 6, 2020 •
edited

Motivation for this change

The visual client p4v already has a package, this adds the command-line client.
@nioncode, @nathyong, I set you as maintainers because you already have the p4v package and this is pretty similar, I hope that’s ok.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nioncode February 6, 2020 13:25
nioncode
nioncode approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@nioncode nioncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Flakebi
Copy link
Member Author

Flakebi commented Feb 13, 2020

I also updated p4v.
It seems like the packages get updated in-place without changing the url though.
So e.g. the p4 package that I originally proposed did not work anymore now.
Any idea how to solve this? should we just use an older version which does not get updated anymore?

@ofborg ofborg bot requested a review from nioncode February 13, 2020 09:20
@Flakebi
Copy link
Member Author

Flakebi commented Jul 16, 2020

I guess there is not really a good way to package this if they regularly change the archive behind the link.

@Flakebi Flakebi closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nioncode nioncode Awaiting requested review from nioncode

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @nioncode