Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.32.0 -> 1.34.2 (cherry-pick on staging-19.09) #79383

Merged
merged 4 commits into from Feb 7, 2020
Merged

libuv: 1.32.0 -> 1.34.2 (cherry-pick on staging-19.09) #79383

merged 4 commits into from Feb 7, 2020

Conversation

basvandijk
Copy link
Member

Motivation for this change

This should fix some flaky tests on darwin: #79372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-ryantm @basvandijk
libuv: 1.32.0 -> 1.33.1
72456e8 
(cherry picked from commit 5728d7d)
@r-ryantm @basvandijk
libuv: 1.33.1 -> 1.34.0
3937c7c 
(cherry picked from commit ef135db)
@r-ryantm @basvandijk
libuv: 1.34.0 -> 1.34.1
a977e8a 
(cherry picked from commit 6a6ba8f)
@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Closed
10 tasks
@basvandijk
Copy link
Member Author

@GrahamcOfBorg build libuv

@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Closed
@ofborg ofborg bot requested a review from cstrahan February 6, 2020 20:53
@basvandijk
libuv: 1.34.1 -> 1.34.2
54e54d6 
(cherry picked from commit 21ad5c1)
@basvandijk basvandijk merged commit bcb79e4 into NixOS:staging-19.09 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @r-ryantm