Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.34.1 -> 1.34.2 #79381

Merged
merged 1 commit into from
Feb 7, 2020
Merged

libuv: 1.34.1 -> 1.34.2 #79381

merged 1 commit into from
Feb 7, 2020
+4 −4

Conversation

basvandijk
Copy link
Member

Motivation for this change

This should fix some flaky tests on darwin: #79372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Closed
10 tasks
@basvandijk
Copy link
Member Author

@GrahamcOfBorg build libuv

@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Closed
@ofborg ofborg bot requested a review from cstrahan February 6, 2020 20:40
@basvandijk
libuv: 1.34.1 -> 1.34.2

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: CED392DE0C483D00
Learn about vigilant mode
21ad5c1
@basvandijk basvandijk force-pushed the libuv-1.34.2-staging branch from 2c2ef2c to 21ad5c1 Compare February 6, 2020 21:12
@basvandijk basvandijk merged commit 97eda56 into NixOS:staging Feb 7, 2020
@thefloweringash thefloweringash mentioned this pull request Jul 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@basvandijk