New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handbrake: 1.3.0 -> 1.3.1 #79384
handbrake: 1.3.0 -> 1.3.1 #79384
Conversation
If I recall correctly, upstream complained about not using their provided tarball. |
Lgtm - @bbigras, try removing that flag to see if it is still needed? |
It builds and |
@bbigras Thank you. |
@jtojnar Story of this package was such: TL;DR Some files/data included only into official site tarball, so the mutual decision with them then was not to have the same tarball, but for Nix to fetch the tarball from the official site. If I remember correctly, they have their own internal elaborate versioning system, that also had been changed a couple of times, and that versioning system files are included into site tarball, but absent from GitHub tarball, so the compilation of the latter falls with an error due to absence of that version information. |
Please review when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. NixOS test runs through, GUI runs fine.
Thanks! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)/nix/store/j04a75bb47xq3zc43x78vkqbanw2l4ld-handbrake-1.3.0 638.2M
/nix/store/12hv0y40c1fvx8gafh2h8l9kw22fla01-handbrake-1.3.1 638.2M
Note The URL changed... Wouldn't it be better to fetch from github instead?