Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake: 1.3.0 -> 1.3.1 #79384

Merged
merged 1 commit into from Feb 9, 2020
Merged

handbrake: 1.3.0 -> 1.3.1 #79384

merged 1 commit into from Feb 9, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/j04a75bb47xq3zc43x78vkqbanw2l4ld-handbrake-1.3.0 638.2M
/nix/store/12hv0y40c1fvx8gafh2h8l9kw22fla01-handbrake-1.3.1 638.2M

Note The URL changed... Wouldn't it be better to fetch from github instead?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 6, 2020

If I recall correctly, upstream complained about not using their provided tarball.

@bbigras
Copy link
Contributor Author

bbigras commented Feb 7, 2020

@wmertens
Copy link
Contributor

wmertens commented Feb 7, 2020

Lgtm - @bbigras, try removing that flag to see if it is still needed?

@bbigras
Copy link
Contributor Author

bbigras commented Feb 7, 2020

It builds and nixos/tests/handbrake.nix runs without the flag so I removed it.

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Feb 8, 2020

@bbigras Thank you.

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Feb 8, 2020

@jtojnar Story of this package was such:

TL;DR
They have different tarballs on GitHub and on the official site.

Some files/data included only into official site tarball, so the mutual decision with them then was not to have the same tarball, but for Nix to fetch the tarball from the official site. If I remember correctly, they have their own internal elaborate versioning system, that also had been changed a couple of times, and that versioning system files are included into site tarball, but absent from GitHub tarball, so the compilation of the latter falls with an error due to absence of that version information.

@bbigras
Copy link
Contributor Author

bbigras commented Feb 8, 2020

Please review when you have time.

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. NixOS test runs through, GUI runs fine.

@JohnAZoidberg JohnAZoidberg merged commit ff1018a into NixOS:master Feb 9, 2020
@bbigras bbigras deleted the handbrake branch February 9, 2020 21:56
@bbigras
Copy link
Contributor Author

bbigras commented Feb 9, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants