Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: update set #79410

Merged
merged 1 commit into from Feb 7, 2020
Merged

nodePackages: update set #79410

merged 1 commit into from Feb 7, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Feb 7, 2020 •
edited

Motivation for this change

https://github.com/angular/angular-cli/releases/tag/v9.0.0
https://github.com/angular/angular-cli/releases/tag/v9.0.1

Supercedes / closes #78151 (?)

Also, I don't see pkgs/development/node-packages/composition-v13.nix in #78151. Is this something that is necessary?

Note that #73225 still seems to be present
Applying the patch still seems to fix the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs evanjs requested a review from Mic92 February 7, 2020 03:43
@Mic92 Mic92 merged commit 862105d into NixOS:master Feb 7, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 7, 2020

cc @hlolli lumo is broken: https://gist.github.com/Mic92/e7ac6eb8652b72ddc9e5a349b8e7bc23

@hlolli
Copy link
Member

hlolli commented Feb 7, 2020

does this -> #59414 fix it? @Mic92

@hlolli
Copy link
Member

hlolli commented Feb 7, 2020

oops, it's ofc out of sync, I'll rebase and test it. Not sure if I can do it this weekend. Next week. Will update.

@evanjs evanjs deleted the @angular-cli/9.0.1 branch February 7, 2020 16:46
@evanjs evanjs mentioned this pull request Feb 7, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @Mic92 @hlolli