Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corerad: 0.1.9 -> 0.2.1 #79409

Merged
merged 2 commits into from Feb 10, 2020
Merged

corerad: 0.1.9 -> 0.2.1 #79409

merged 2 commits into from Feb 10, 2020

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Feb 7, 2020

Motivation for this change

Version bump and minor configuration change for CoreRAD and its NixOS module test. Same ideas as my previous PR: #78034.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tests pass:

router # [   84.260566] corerad[762]: 2020/02/07 03:04:14 CoreRAD v0.2.0 (BETA) starting with configuration file "/nix/store/2sj89rv38pfp9a9zp4cbaimad3039qx9-corerad.toml"
router # [   84.716619] corerad[762]: 2020/02/07 03:04:15 eth1: "prefix": ::/64 [on-link, autonomous], preferred: 4h0m0s, valid: 24h0m0s
router # [   84.784834] corerad[762]: 2020/02/07 03:04:15 eth1: "lla": source link-layer address: 52:54:00:12:01:02
router # [   84.874558] corerad[762]: 2020/02/07 03:04:15 eth1: initialized, advertising from fe80::5054:ff:fe12:102
client: waiting for the VM to finish booting
client: connected to guest root shell
client: (connecting took 0.00 seconds)
(0.12 seconds)
client: waiting for success: ping -c 1 fd00:dead:beef:dead::1
(0.18 seconds)
(94.61 seconds)
Verify SLAAC on client
client: waiting for success: rdisc6 -1 -r 10 eth1
(0.63 seconds)
client: waiting for success: ip -6 addr show dev eth1 | grep -q 'fd00:dead:beef:dead:'
client # [   90.410541] systemd-logind[819]: New seat seat0.
client # [   90.455299] systemd-logind[819]: Watching system buttons on /dev/input/event2 (Power Button)
(0.36 seconds)
client: must succeed: ip -6 addr show dev eth1
(0.08 seconds)
2 out of 2 tests succeeded
test script finished in 97.47s
cleaning up
killing client (pid 9)
killing router (pid 21)
(0.01 seconds)
/nix/store/r30aymks0ks21v7g3hfa7q583a3ga00h-vm-test-run-unnamed

/cc @danderson @jonringer (thanks again for the reviews!)

@ofborg ofborg bot added the 6.topic: nixos label Feb 7, 2020
@ofborg ofborg bot requested a review from kalbasit February 7, 2020 03:32
@mdlayher
Copy link
Member Author

mdlayher commented Feb 7, 2020

@GrahamcOfBorg test corerad

kalbasit
kalbasit previously requested changes Feb 7, 2020
View reviewed changes
pkgs/tools/networking/corerad/default.nix Outdated Show resolved Hide resolved
@mdlayher
Copy link
Member Author

mdlayher commented Feb 7, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

mdlayher commented Feb 7, 2020

@kalbasit thanks for the review! Fixed.

@ofborg ofborg bot requested a review from kalbasit February 7, 2020 15:16
@mdlayher mdlayher changed the title corerad: 0.1.9 -> 0.2.0 corerad: 0.1.9 -> 0.2.1 Feb 9, 2020
@mdlayher
Copy link
Member Author

mdlayher commented Feb 9, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

mdlayher commented Feb 9, 2020

I made some development progress in the past few days and have just bumped to 0.2.1 with a new commit. I hope that's alright, but let me know if not.

@jonringer
Copy link
Contributor

more than alright, :)

jonringer
jonringer requested changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind squashing the commits:

corerad: 0.1.9 -> 0.2.1
nixos/corerad: update advertisement argument

@mdlayher
Copy link
Member Author

mdlayher commented Feb 9, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

mdlayher commented Feb 9, 2020

I made a quick git rebase mistake but appear to have fixed it up. Thanks for the reviews!

jonringer
jonringer approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/79409
1 package built:
corerad

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer jonringer merged commit 065ec9a into NixOS:master Feb 10, 2020
@mdlayher mdlayher deleted the mdl-corerad-beta branch January 4, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdlayher @jonringer @kalbasit