Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.33.1 -> 0.34.1 #79282

Closed
wants to merge 1 commit into from
Closed

starship: 0.33.1 -> 0.34.1 #79282

wants to merge 1 commit into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Feb 5, 2020 •
edited

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.34.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member

Frostman commented Feb 5, 2020

nixpkgs-review failed with the following output:

builder for '/nix/store/ifsagdc7vcmb9zlqwk7rp3vqsphv08rf-starship-0.34.1.drv' failed with exit code 101; last 10 log lines:
  ...
  376 |         let node_dc = DirContents::from_path(&PathBuf::from(node.path()))?;
      |                                    ^^^^^^^^^ function or associated item not found in `context::DirContents`

  error: aborting due to 4 previous errors

  For more information about this error, try `rustc --explain E0599`.
  error: could not compile `starship`.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/rz4ybw1h3nphk8pcfzpyy36viihfqsbb-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/rz4ybw1h3nphk8pcfzpyy36viihfqsbb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79282
1 package failed to build:
starship

@bbigras
Copy link
Contributor

bbigras commented Feb 5, 2020

I got the same error.

@ofborg ofborg bot requested review from bbigras and davidtwco February 5, 2020 16:34
@bbigras
Copy link
Contributor

bbigras commented Feb 6, 2020

Please try with v0.35.0 which should fix the problem.

@davidtwco
Copy link
Member

Please try with v0.35.0 which should fix the problem.

v0.35.1 has also been released.

@Ma27 Ma27 closed this in bead83e Feb 6, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 6, 2020

Did the update and added @filalex77 as co-author :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras Awaiting requested review from bbigras

@davidtwco davidtwco Awaiting requested review from davidtwco

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Br1ght0ne @Frostman @bbigras @davidtwco @Ma27