Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hey: init at 0.1.3 #79281

Merged
merged 1 commit into from Feb 26, 2020
Merged

hey: init at 0.1.3 #79281

merged 1 commit into from Feb 26, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Feb 5, 2020 •
edited

Motivation for this change

https://github.com/rakyll/hey/releases/tag/v0.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested a review from kalbasit February 5, 2020 16:22
Frostman
Frostman suggested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@Frostman Frostman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review passed ok, binary works correctly.

pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
@Frostman
Copy link
Member

Frostman commented Feb 10, 2020 •
edited

Change LGTM, verified with nixpkgs-review, binary works correctly (NixOS, x86_64). Thank you!

lukateras
lukateras reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
@Br1ght0ne
Copy link
Member Author

Thanks, @Frostman and @yegortimoshenko!

@lukateras
Copy link
Member

@GrahamcOfBorg build hey

@lukateras lukateras merged commit d7a0351 into NixOS:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Frostman approved these changes

@lukateras lukateras lukateras approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @Frostman @lukateras