Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbtools: 0.7.2 -> 1.0.2 #79338

Merged
merged 1 commit into from Feb 13, 2020
Merged

rbtools: 0.7.2 -> 1.0.2 #79338

merged 1 commit into from Feb 13, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Feb 6, 2020

Motivation for this change

Update to 1.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please disable python2, or conditionally add the dependencies:

warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/b8i46ql65rypgxlw3b4gbn30zsaa3rgz-python2.7-rbtools-1.0.2.drv' failed with exit code 1; last 10 log lines:
  installing
  Executing pipInstallPhase
  /build/RBTools-1.0.2/dist /build/RBTools-1.0.2
  DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
  Processing ./RBTools-1.0.2-py2.py3-none-any.whl
  Requirement already satisfied: texttable in /nix/store/xrw9dhn1hl3a7ik46ck10nlg5pjf3sr5-python2.7-texttable-1.6.2/lib/python2.7/site-packages (from RBTools==1.0.2) (1.6.2)
  Requirement already satisfied: tqdm in /nix/store/mykga16w0yqgmb2q25zyygyr6lwwzl1m-python2.7-tqdm-4.42.1/lib/python2.7/site-packages (from RBTools==1.0.2) (4.42.1)
  Requirement already satisfied: six>=1.8.0 in /nix/store/wn71mqksln59crkmfyz64xj50ycfczhz-python2.7-six-1.14.0/lib/python2.7/site-packages (from RBTools==1.0.2) (1.14.0)
  ERROR: Could not find a version that satisfies the requirement backports.shutil-get-terminal-size; python_version < "3.0" (from RBTools==1.0.2) (from versions: none)
  ERROR: No matching distribution found for backports.shutil-get-terminal-size; python_version < "3.0" (from RBTools==1.0.2)
cannot build derivation '/nix/store/kicg5dlwmg2ncb67gcdmnpzx95c33zgg-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 4 copied (0.4 MiB), 0.1 MiB DL]
error: build of '/nix/store/kicg5dlwmg2ncb67gcdmnpzx95c33zgg-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79338
1 package failed to build:
python27Packages.rbtools

2 package built:
python37Packages.rbtools python38Packages.rbtools

@jonringer
Copy link
Contributor

you should run nixpkgs-review on your own PRs, makes it a lot easier to merge if it passes

@Flakebi
Copy link
Member Author

Flakebi commented Feb 13, 2020

Thanks for the review @jonringer!
I’ll make sure to use nixpkgs-review :)
It passes now, I hope this is the right way to disable python2 support for this package.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more future proofing for updates

pkgs/development/python-modules/rbtools/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executables show usage

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79338
2 package built:
python37Packages.rbtools python38Packages.rbtools

@jonringer jonringer merged commit 08a304f into NixOS:master Feb 13, 2020
@Flakebi Flakebi deleted the rbtools branch February 14, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants