New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbtools: 0.7.2 -> 1.0.2 #79338
rbtools: 0.7.2 -> 1.0.2 #79338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please disable python2, or conditionally add the dependencies:
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/b8i46ql65rypgxlw3b4gbn30zsaa3rgz-python2.7-rbtools-1.0.2.drv' failed with exit code 1; last 10 log lines:
installing
Executing pipInstallPhase
/build/RBTools-1.0.2/dist /build/RBTools-1.0.2
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Processing ./RBTools-1.0.2-py2.py3-none-any.whl
Requirement already satisfied: texttable in /nix/store/xrw9dhn1hl3a7ik46ck10nlg5pjf3sr5-python2.7-texttable-1.6.2/lib/python2.7/site-packages (from RBTools==1.0.2) (1.6.2)
Requirement already satisfied: tqdm in /nix/store/mykga16w0yqgmb2q25zyygyr6lwwzl1m-python2.7-tqdm-4.42.1/lib/python2.7/site-packages (from RBTools==1.0.2) (4.42.1)
Requirement already satisfied: six>=1.8.0 in /nix/store/wn71mqksln59crkmfyz64xj50ycfczhz-python2.7-six-1.14.0/lib/python2.7/site-packages (from RBTools==1.0.2) (1.14.0)
ERROR: Could not find a version that satisfies the requirement backports.shutil-get-terminal-size; python_version < "3.0" (from RBTools==1.0.2) (from versions: none)
ERROR: No matching distribution found for backports.shutil-get-terminal-size; python_version < "3.0" (from RBTools==1.0.2)
cannot build derivation '/nix/store/kicg5dlwmg2ncb67gcdmnpzx95c33zgg-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 4 copied (0.4 MiB), 0.1 MiB DL]
error: build of '/nix/store/kicg5dlwmg2ncb67gcdmnpzx95c33zgg-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79338
1 package failed to build:
python27Packages.rbtools
2 package built:
python37Packages.rbtools python38Packages.rbtools
you should run |
Thanks for the review @jonringer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more future proofing for updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
executables show usage
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79338
2 package built:
python37Packages.rbtools python38Packages.rbtools
Motivation for this change
Update to 1.0.2
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)