Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtail: 3.0.0-rc4 -> 3.0.0-rc34 #79356

Merged
merged 1 commit into from Mar 18, 2020
Merged

mtail: 3.0.0-rc4 -> 3.0.0-rc34 #79356

merged 1 commit into from Mar 18, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020 •
edited

Motivation for this change

3.0.0-rc4 is over 2 years old. no release yet...

Things done

This update has a tiny lie.

I saw from the manual that go2nix is normally used for goDeps but on the go2nix repo it says to use vgo2nix when there a go.mod file present.

The thing is that vgo2nix fails with 3.0.0-rc34 but not with master, so I generated the file with master. master only has tiny changes. It's mostly a deps update. (check google/mtail@v3.0.0-rc34...0150dad)

If it's not OK I could another way. I also wanted to switch the package to buildGoModule but I got some problem: #79355

Also, is gotools needed?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/z0dk0mhfsni2lpaqpw2pnjgs0y9vzsyl-mtail-3.0.0-rc4-bin 40.4M
/nix/store/1m6f7yfly52fpa4rwwsvwqkrxmfd7h8a-mtail-3.0.0-rc35 45.5M

@bbigras
Copy link
Contributor Author

bbigras commented Feb 6, 2020

Another tiny thing is that mtail --version will print:
mtail version 3.0.0-rc34 git revision invalid:-use-make-to-build go version go1.13.7 go arch amd64 go os linux

since I only set Version. We could also set Branch and Revision.

https://github.com/google/mtail/blob/7b4270cb6e8b6ed1f2febe48e370cb68d38681f9/cmd/mtail/main.go#L77-L80

@ofborg ofborg bot requested a review from ehmry February 6, 2020 15:50
@bbigras
Copy link
Contributor Author

bbigras commented Feb 6, 2020

It seems my problem with buildGoModule doesn't happen anymore. I made the change to use buildGoModule now.

@ofborg ofborg bot requested a review from kalbasit February 6, 2020 17:54
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/115

@bbigras
Copy link
Contributor Author

bbigras commented Mar 3, 2020

done, thanks @doronbehar

doronbehar
doronbehar reviewed Mar 3, 2020
View reviewed changes
pkgs/servers/monitoring/mtail/default.nix Outdated Show resolved Hide resolved
pkgs/servers/monitoring/mtail/default.nix Show resolved Hide resolved
pkgs/servers/monitoring/mtail/default.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Mar 7, 2020

I done all the changes and updated to rc35. thanks

doronbehar
doronbehar approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tested basic --help and no comments left :).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/114

@nh2 nh2 merged commit 4366606 into NixOS:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @nixos-discourse @doronbehar @nh2