Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7974: Crash when CTRL+click to show a vehicle group that is coll… #7975

Merged
merged 1 commit into from Feb 6, 2020
Merged

Fix #7974: Crash when CTRL+click to show a vehicle group that is coll… #7975

merged 1 commit into from Feb 6, 2020

Conversation

stormcone
Copy link
Contributor

…apsed

Maybe we should add this->group_sb->SetCount((uint)this->groups.size()); to BuildGroupList().

LordAro
LordAro approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine, I feel like BuildGroupList should be "independent" of the scrollbars

@LordAro LordAro merged commit 492d270 into OpenTTD:master Feb 6, 2020
@stormcone stormcone deleted the fix-7974 branch February 15, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stormcone @LordAro