Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpcurl: 1.0.0 -> 1.4.0 #79361

Merged
merged 1 commit into from Feb 7, 2020
Merged

grpcurl: 1.0.0 -> 1.4.0 #79361

merged 1 commit into from Feb 7, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change

1.0.0 is over a year old.

Things done

I didn't build on darwin. I have no idea if the 2 distinct deps files are still required.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/7nk0jmh4s64vr333v6bgibh6g449wv24-grpcurl-1.0.0-bin 61.1M
/nix/store/s7s1rx0vqvb76makhr39fcajddznb2sr-grpcurl-1.4.0-bin 63.3M

@ofborg ofborg bot requested review from knl and ehmry February 6, 2020 16:38
@knl
Copy link
Contributor

knl commented Feb 6, 2020

@GrahamcOfBorg build grpcurl

@knl
Copy link
Contributor

knl commented Feb 7, 2020

I've built this on my macOS and can confirm it builds and works there.

knl
knl approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@knl knl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I tested it on darwin as well.

@basvandijk basvandijk merged commit a7ae4cb into NixOS:master Feb 7, 2020
@bbigras bbigras deleted the grpcurl branch February 7, 2020 14:45
@bbigras
Copy link
Contributor Author

bbigras commented Feb 7, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knl knl knl approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @knl @basvandijk