Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jirafeau: init at 4.1.1 + module #79363

Merged
merged 2 commits into from Feb 18, 2020
Merged

jirafeau: init at 4.1.1 + module #79363

merged 2 commits into from Feb 18, 2020

Conversation

davidtwco
Copy link
Member

Motivation for this change

Adds a package for Jirafeau and a module for configuring and running Jirafeau.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidtwco
jirafeau: init at 4.1.1
24adffd 
Signed-off-by: David Wood <david.wood@codeplay.com>
@davidtwco
nixos/jirefeau: add services.jirafeau module
65accd0 
Signed-off-by: David Wood <david.wood@codeplay.com>
jonringer
jonringer reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM (but I'm not great at nixos modules)

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79363
1 package blacklisted:
tests.nixos-functions.nixos-test

1 package built:
jirafeau

however, running the tests i get:

machine: connected to guest root shell
machine: (connecting took 0.00 seconds)
(0.00 seconds)
error: [Errno 32] Broken pipe
cleaning up
killing machine (pid 9)
(0.00 seconds)
builder for '/nix/store/170yvxcmcv3dvwdx98a8hsqk3k3y9mhc-vm-test-run-jirafeau.drv' failed with exit code 1
error: build of '/nix/store/170yvxcmcv3dvwdx98a8hsqk3k3y9mhc-vm-test-run-jirafeau.drv' failed

@jonringer
Copy link
Contributor

@GrahamcOfBorg test jirafeau

@davidtwco
Copy link
Member Author

It appears that the test passes for ofborg and it still passes for me locally.

@jonringer jonringer merged commit 60a3d9d into NixOS:master Feb 18, 2020
@davidtwco davidtwco deleted the jirafeau-init branch February 18, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @jonringer