-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatpak: 1.4.2 → 1.6.1 #79416
flatpak: 1.4.2 → 1.6.1 #79416
Conversation
fc3ef3d
to
4d50acd
Compare
xdg-desktop-portals installed tests are currently broken due to flatpak/xdg-desktop-portal#428. (does not apply cleanly 😞) |
# Patch from https://github.com/ostreedev/ostree/pull/1633 | ||
./01-Drop-ostree-trivial-httpd-CLI-move-to-tests-director.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should re PR this patch since we're keeping it in syrc
Currently trying to run the flatpak installed tests in my user session as it was getting stuck in the VM as well. Had to rebuild gnome-desktop-testing from master because v2018.1 logs statuses to journal, making it hard to match them to the test outputs. |
Got it down to three tests if the new fixes did not break the previous one:
But now it fails in https://github.com/flatpak/flatpak/blob/1.6.1/tests/test-bundle.sh#L75 and https://github.com/flatpak/flatpak/blob/1.6.1/tests/test-run.sh#L56.
This is the command that fails:
I noticed that it gets fixed just by adding
So in 3217f20, I hardcoded all the binary paths referring to all the |
Turns out it was picking up the triggers from the system service 🤦♀️ Now ostree and flatpak tests pass in my profile, trying installed tests. Marked the xdg-desktop-portal as broken since there is too many patches needed. |
I also threw |
There is still something wrong with the installed test run in VM. I had it running for over ten hours but it remained stuck. I would expect it to timeout after 3600 seconds as specified at least.
|
I think we can get this in for 20.03, the tests did work in the session right? |
required by rpm-ostree
* Update Changes: rpm-software-management/librepo@1.9.2...1.11.2 * Split into multiple outputs * Default to Python 3 like upstream does
* https://github.com/flatpak/flatpak/releases/tag/1.4.3 * https://github.com/flatpak/flatpak/releases/tag/1.5.0 * https://github.com/flatpak/flatpak/releases/tag/1.5.1 * https://github.com/flatpak/flatpak/releases/tag/1.5.2 * https://github.com/flatpak/flatpak/releases/tag/1.6.0 * https://github.com/flatpak/flatpak/releases/tag/1.6.1
* https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.6.0 * https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.5.4 * https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.5.3 * https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.5.2 * https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.5.1 * https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.5.0
Update to master since the stable version prints to journal even when running in terminal, which is annoying. Also clean up the expression.
59b5589
to
e3cbebf
Compare
flatpak: 1.4.2 → 1.6.1 (cherry picked from commit 09f7e37)
Hi there, I suspect my configurations got some breakages because of this update. I wrote it up here: https://discourse.nixos.org/t/flatpak-error-the-name-org-freedesktop-accounts-was-not-provided-by-any-service-file/6000 Any suggestions for how to debug or fix? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
…
Closes: #78793