Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgp: init at 1.7.0.29 #79343

Merged
merged 2 commits into from Apr 2, 2020
Merged

rgp: init at 1.7.0.29 #79343

merged 2 commits into from Apr 2, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Feb 6, 2020 •
edited

Motivation for this change

Add a package for the Radeon GPU Profiler, a useful tool to profile graphics applications on AMD GPUs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timokau
timokau requested changes Mar 31, 2020
View reviewed changes
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Show resolved Hide resolved
@Flakebi
Copy link
Member Author

Flakebi commented Apr 1, 2020

Thanks for taking a look @timokau and pointing me to the documentation, it should be better now.

timokau
timokau requested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost perfect to me now. One more fix is needed, then this should be good to go.

pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
timokau
timokau approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. I'll give @Mic92 opportunity to disagree, since he had some comments as well. If nobody merged this by tomorrow, please ping me again.

pkgs/development/tools/rgp/default.nix Outdated
, qtbase
, zlib
}:
with lib;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just now noticed that this with isn't necessary at all. Given the previously linked IRC discussion, it should probably be removed. I don't think its important enough to hold off merge even longer though.

Mic92
Mic92 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mic92 Mic92 merged commit d343d70 into NixOS:master Apr 2, 2020
@Flakebi
Copy link
Member Author

Flakebi commented Apr 2, 2020

Thanks!

@Flakebi Flakebi deleted the rgp branch April 2, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @Mic92 @timokau