New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.arcanist-vim: init at 2016-05-27 #79312
Conversation
|
6ed3f79
to
2407361
Compare
After rebasing and re-updating today
|
c60e5d5
to
50ac105
Compare
de-novo
|
cc. @jonringer |
sorry, do you mind rebasing again. Been caught up with moving then was traveling |
50ac105
to
1b73226
Compare
Done, @jonringer :) Testing |
Getting a failure of an unrelated plugin:
|
This patch fixes the failure, should I apply it @jonringer ? diff --git a/pkgs/misc/vim-plugins/vim-plugin-names b/pkgs/misc/vim-plugins/vim-plugin-names
index 0fc5edffe48..3081f2383f2 100644
--- a/pkgs/misc/vim-plugins/vim-plugin-names
+++ b/pkgs/misc/vim-plugins/vim-plugin-names
@@ -30,7 +30,6 @@ bogado/file-line
bohlender/vim-smt2
brennanfee/vim-gui-position
bronson/vim-trailing-whitespace
-brooth/far.vim
carlitux/deoplete-ternjs
ccarpita/rtorrent-syntax-file
cespare/vim-toml |
I posted the issue here: brooth/far.vim#84 it's an upstream issue. If it lasts more than a day, I will mark it broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
failure unrelated to PR, but upstreamed: brooth/far.vim#84
[5 built (1 failed), 55 copied (274.7 MiB), 62.5 MiB DL]
error: build of '/nix/store/4mv1566gnsm9k7v5ai23sf57nx8nlac2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79312
1 package failed to build:
vimPlugins.far-vim
2 package built:
vimPlugins.arcanist-vim vimPlugins.vim-phabricator
Motivation for this change
I noticed it was missing, also noticed the list was out of ordered and added a commit sorting it again.
Edit
I also added https://github.com/jparise/vim-phabricator
@jonringer
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)