Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.34.1 -> 1.34.2 #79372

Closed
wants to merge 1 commit into from
Closed

libuv: 1.34.1 -> 1.34.2 #79372

wants to merge 1 commit into from

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Feb 6, 2020 •
edited

Motivation for this change

This should fix some flaky tests on darwin: libuv/libuv#2675

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build libuv

This was referenced Feb 6, 2020
Closed
Closed
@ofborg ofborg bot requested a review from cstrahan February 6, 2020 19:14
@FRidh FRidh added this to WIP in Staging via automation Feb 6, 2020
@FRidh
Copy link
Member

FRidh commented Feb 6, 2020

This needs to target staging.

@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Merged
10 tasks
@basvandijk
Copy link
Member Author

Closing in favor of: #79381.

@basvandijk basvandijk closed this Feb 6, 2020
Staging automation moved this from WIP to Done Feb 6, 2020
@basvandijk basvandijk mentioned this pull request Feb 6, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @FRidh