Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(19.09) gogs: 0.11.86 -> 0.11.91, fixes CVE-2019-14544 #79315

Merged
merged 1 commit into from Feb 6, 2020
Merged

(19.09) gogs: 0.11.86 -> 0.11.91, fixes CVE-2019-14544 #79315

merged 1 commit into from Feb 6, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 6, 2020 •
edited

(cherry picked from commit 3cd72fb)

Motivation for this change

Backport for 19.09 of PR #79314

Update and fix for CVE-2019-14544, CVSS 3 Score 9.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

Tested on my "production" machine

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/91

lsix
lsix approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built, all good for me.

Thanks.

@lsix lsix merged commit 9af8512 into NixOS:release-19.09 Feb 6, 2020
@lsix
Copy link
Member

lsix commented Feb 6, 2020

Given the security fix, I am ok to port to release-19.09.

@lsix
Copy link
Member

lsix commented Feb 6, 2020

we could also have backported gogs/gogs@c3af3ff but since this is not a major update 👍

@Moredread Moredread deleted the gogs-0.11.91-stable branch February 6, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@schneefux schneefux schneefux approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Moredread @nixos-discourse @lsix @schneefux