Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.chromium: Port to Python #79352

Merged
merged 1 commit into from Feb 6, 2020
Merged

nixosTests.chromium: Port to Python #79352

merged 1 commit into from Feb 6, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Feb 6, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc mentioned this pull request Feb 6, 2020
Closed
@tfc
Copy link
Contributor Author

tfc commented Feb 6, 2020

@GrahamcOfBorg test chromium

@tfc
Copy link
Contributor Author

tfc commented Feb 6, 2020

@GrahamcOfBorg test chromium

@flokli
Copy link
Contributor

flokli commented Feb 6, 2020

x86_64 timed out as it tried to build chromium. As aarch64 succeeded, LGTM.

@flokli flokli merged commit c4402ea into NixOS:master Feb 6, 2020
@tfc tfc deleted the port-chromium-test branch February 6, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfc @flokli @worldofpeace