Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Pipelines] upgrade to macOS Catalina (10.15) #21628

Closed
wants to merge 4 commits into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 6, 2020

No description provided.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 February 6, 2020 10:26 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 February 6, 2020 11:51 Inactive
@foolip foolip force-pushed the foolip/catalina branch 2 times, most recently from 9425bb8 to 074f0b1 Compare February 12, 2020 08:21
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 February 12, 2020 08:26 Inactive
@foolip
Copy link
Member Author

foolip commented Feb 12, 2020

It looks as though sudo safaridriver --enable doesn't work again, similar to in #19845. The error is "SessionNotCreatedException: session not created (500): Could not create a session: You must enable the 'Allow Remote Automation' option in Safari's Develop menu to control Safari via WebDriver."

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 February 12, 2020 09:17 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 24, 2020 11:06 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 16:14 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 16:48 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 16:56 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 17:31 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 17:39 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 17:48 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 17:57 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 18:15 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 April 29, 2020 18:23 Inactive
@LukeZielinski
Copy link
Contributor

Looks like TaskCluster didn't run here, retrying.

@stephenmcgruer
Copy link
Contributor

Looks like TaskCluster didn't run here, retrying.

This is a draft PR, TaskCluster doesn't run on drafts.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 May 6, 2020 20:07 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 1, 2020 14:27 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 12, 2020 16:30 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 12, 2020 16:38 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 12, 2020 16:55 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 12, 2020 17:07 Inactive
@stephenmcgruer
Copy link
Contributor

Unfortunately at this point we're quite stuck on this issue. Folks from Apple have been unable to figure it out even with additional logging:

I am unable to reproduce the Azure issue on a vanilla customer build with Safari Technology Preview 108.
If I had to guess, something weird is going on, such as running safaridriver via a non-UI shell
or weird permissions to ~/Library/
Unfortunately no error is returned on the file write operation, so it's hard to say what it thinks is going on.

We've tried various things to make the plist file appear, but it just won't. Without ssh-access to the bots for interactive debugging, we're rather out of options.

To guard against 'what happens when Catalina becomes the default MacOS', I guess we should experiment and see if we can use a workaround plist file again.

@Hexcles
Copy link
Member

Hexcles commented Jun 12, 2020

I tried to reproduce it locally and failed, but had some interesting observations.

~/Library/WebDriver seems super special from the perspective of a Linux user. The directory did not exist until I ran sudo "/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver" --enable, which created the directory that belongs to me (the primary user) instead of root:

ls -ld ~/Library/WebDriver
drwxr-xr-x  3 robertma  primarygroup  96 12 Jun 15:25 /Users/robertma/Library/WebDriver

However, I cannot cd or ls it. I tried a root shell (via sudo -i) and I could cd into it but still couldn't ls. I managed to open it in Finder (Library is hidden by default in Finder) and found com.apple.SafariTechnologyPreview.plist in there, which I was able to open with VSCode:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>AllowRemoteAutomation</key>
	<true/>
</dict>
</plist>

Even with the full path name, I still can't access the file in a terminal at all.

If we suspect something is wrong with this plist, how can we debug it in a script? I don't think our current attempt of ls -l -@ ~/Library/WebDriver is useful if we can't even open it.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21628 June 12, 2020 20:21 Inactive
@stephenmcgruer
Copy link
Contributor

Well (sigh) the plist hack that we used to use appears to work again (aka copy the plist @Hexcles provided instead of calling safaridriver --enable).

I'm going to try a 'clean' version of this PR and push it to safari triggers to confirm.

@stephenmcgruer
Copy link
Contributor

Well (sigh) the plist hack that we used to use appears to work again (aka copy the plist @Hexcles provided instead of calling safaridriver --enable).

Or... maybe it doesn't. Still a bunch of errors in the infra tests, just less familiar ones (NoSuchFrameException: no such frame (404):, JavascriptErrorException: javascript error (500): A JavaScript exception occured: window.__wptrunner_process_next_event is not a function. (In 'window.__wptrunner_process_next_event()', 'window.__wptrunner_process_next_event' is undefined), ...).

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-21628 July 15, 2020 11:13 Pending
@gsnedders
Copy link
Member

obsoleted by #24812

@gsnedders gsnedders closed this Aug 10, 2020
@foolip foolip deleted the foolip/catalina branch August 12, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants