Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amaranth-lang/amaranth
base: 97cc78a3db54
Choose a base ref
...
head repository: amaranth-lang/amaranth
compare: a1c58633e644
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 6, 2020

  1. hdl.dsl: make referencing undefined FSM states an error. 

    Before this commit, doing something like:

    with m.FSM():
        with m.State("FOO"):
            m.next = "bAR"
        with m.State("BAR"):
            m.next = "FOO"

would silently create an empty state `bAR` and get stuck in it until
the module is reset. This was done intentionally (in Migen, this code
would in fact miscompile), but in retrospect was clearly a bad idea;
it turns typos into bugs, while in the rare case that branching to
a completely empty state is desired, it is trivial to define one.

Fixes #315.
    @whitequark
    whitequark committed Feb 6, 2020
    Copy the full SHA
    a1c5863 View commit details
    Browse the repository at this point in the history