Stop using promise_rejects in worklets tests #21637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky
force-pushed
the
promise_rejects-worklets
branch
from
02571e3
to
5afbb66
Compare
|
@bfgeek do you have a review ETA by any chance? |
bzbarsky
force-pushed
the
promise_rejects-worklets
branch
from
5afbb66
to
fc5d8a3
Compare
stephenmcgruer
approved these changes
Feb 13, 2020
worklets/resources/import-tests.js
Outdated
Comment on lines
135
to
136
| '/common/redirect.py?location=' + | ||
| encodeURIComponent(kScriptURL))); |
There was a problem hiding this comment.
Nit-picking, but: this PR has reduced these lines from 4-space indent from the line above to 2-space.
bzbarsky
force-pushed
the
promise_rejects-worklets
branch
from
fc5d8a3
to
4ed78f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.