buildRustCrate: remap the current build dir to / for (more) reproducible builds #79299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
force-pushed
the
buildRustCrate-remap-source-path
branch
from
9f704df
to
56e11bc
Compare
andir
changed the title
|
@GrahamcOfBorg build rustCrateTest |
|
@GrahamcOfBorg build buildRustCrateTests |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Distributed remote builds had been haunted by a reproducibility and compiler error due to metadata in crates not lining up. The issue seems to (partially) be that the metadata in the
.rlibfiles wouldn't always be the same. One impurity that was found now is the source path that is embedded in the files.We can simply set those to
/and have the same root path in all the crates be built. This already allowed me to have bit-by-bit reproducibility for thebrotlicrate used in thebuildRustCratetests.Things done
@GrahamcOfBorg build rustCrateTest