Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isArm #79291

Merged
merged 3 commits into from Feb 8, 2020
Merged

Remove isArm #79291

merged 3 commits into from Feb 8, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Feb 5, 2020

Motivation for this change

isArm has been deprecated for three releases. All references have been removed. Tree-wide substitution was performed in #37401 21 months ago.

The noisy isArm alias causes maintainers/scripts/find-tarballs.nix to generate spurious warnings as it recurses through.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chkno
nodejs: isArm -> isAarch32
9333e47 
This is the last package reference to isArm.  isArm is deprecated after 18.03.
This substitution was performed tree-wide in NixOS#37401.
@chkno
lib.systems.elaborate: isArm -> isAarch32
a7835b9 
This is the last reference to isArm.  isArm is deprecated after 18.03.
This substitution was performed tree-wide in NixOS#37401.
@chkno
stdenv: Remove isArm (use isAarch32 instead)
5d48211 
isArm has been deprecated for three releases.  All references have been
removed.  Tree-wide substitution was performed in NixOS#37401 21 months ago.
@ofborg ofborg bot added the 6.topic: stdenv Standard environment label Feb 5, 2020
@chkno
Copy link
Member Author

chkno commented Feb 5, 2020

(GitHub's web UI is displaying these commits in the wrong order. This is GitHub issue #386. The actual order is visible on this branch's commits page.)

@FRidh FRidh added this to the 20.03 milestone Feb 5, 2020
worldofpeace
worldofpeace approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 1193468 into NixOS:master Feb 8, 2020
@Ericson2314
Copy link
Member

Glad to see this saga concluded :)

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#79291 from chkno/remove-isArm
8fb9441 
Remove isArm

(cherry picked from commit 1193468)
@vcunat vcunat mentioned this pull request Jul 28, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @Ericson2314 @worldofpeace @FRidh