Add github notifications for evals #712
Conversation
|
Maybe it would be good to have unified eval context (instead of one being named after the PR), so one could turn on branch protection on the context being successful. Implemented in: pikajude#1 |
| } | ||
| }; | ||
| if ($@) { | ||
| print STDERR "error processing message '$payload' on channel '$channelName': $@\n"; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is needed. My understanding is that it's used for the test, and I wrote in the test how one can do it differently, alleviating the need for once.
| @@ -88,6 +127,10 @@ for my $build ($db->resultset('Builds')->search( | |||
| my $buildId = $build->id; | |||
| print STDERR "sending notifications for build ${\$buildId}...\n"; | |||
| buildFinished($build); | |||
|
|
|||
There was a problem hiding this comment.
I don't think this is needed. My understanding is that it's used for the test, and I wrote in the test how one can do it differently, alleviating the need for once.
| my $output = $machine->mustSucceed("hydra-notify --once 2>&1"); | ||
| $output =~ m!GithubStatus_Debug POSTing to.*repos/run/jobset/statuses! | ||
| or die "GithubStatus plugin did not activate"; |
There was a problem hiding this comment.
| my $output = $machine->mustSucceed("hydra-notify --once 2>&1"); | |
| $output =~ m!GithubStatus_Debug POSTing to.*repos/run/jobset/statuses! | |
| or die "GithubStatus plugin did not activate"; | |
| $machine->waitUntilSucceeds("journalctl -u hydra-notify.service | grep -G 'GithubStatus_Debug POSTing to.*repos/run/jobset/statuses'"); |
|
I have a modified version of this running on my hydra server, and it seems to work great. If you apply the suggestions and rebase this from master I think it would be a good addition |
Eval notifications are nice. This makes status not get stuck if an evaluation fails.