Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsyslog: add nixos tests to passthru.tests #79390

Merged
merged 1 commit into from Feb 7, 2020
Merged

rsyslog: add nixos tests to passthru.tests #79390

merged 1 commit into from Feb 7, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 6, 2020

ofborg does not build them yet, but at least nixpkgs-update does.
ryantm/nixpkgs-update#118
Note this test passes and would not have detected
#79304

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
rsyslog: add nixos tests to passthru.tests
13b0a6e 
ofborg does not build them yet, but at least nixpkgs-update does.
ryantm/nixpkgs-update#118
Note this test passes and would not have detected
NixOS#79304
@FRidh FRidh requested a review from aanderse February 6, 2020 21:09
@worldofpeace worldofpeace merged commit 39372fa into NixOS:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @worldofpeace