New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Allow autoreplace with same model vehicle #7729
Conversation
There is actually a use for autoreplacing with same model before the end of life. Because of stupid cargo rating calculations it's sometimes beneficial to just autoreplace everything every few years. |
i'd say we should rather change that rating calculation, like give the boost only to vehicles bought in the prototype phase |
Or change it so the effect diminishes based on years from vehicle model introduction date. |
... the details are open for discussion, but i think we should rather fix an exploit rather than design game mechanics to facilitate them. |
Well I did a separate PR to fix that exploit then, #7730 :) |
I feel like there's some helptext somewhere that could be expanded with this fact... |
Also to clarify: This PR does not enable the above exploit. It protects against it by converting any "replace now" into "replace when old" when the replacement vehicle is the same model. Of course that doesn't prevent the player from manually doing a "replace all vehicles now" to a similar model once every year or two. |
Can you explain (again) why autoreplace with same engine (when old) is different/beneficial to autorenew? To me it just seems like adding a 2nd (confusing) way of doing the same thing |
I see two advantages, one is that it might be easier to discover. It doesn't require digging around in the Settings UI. (I haven't been able to think of a good place to put the auto-renew option in the regular GUI.) |
Agreed with @nielsmh. Autoreplace and autorenew should be same, since they do practically the same function that is replacing vehicles, whether it is a different one or the same. That one has to navigate into the settings menu to activate specifically autorenew is highly user unfriendly and confusing to new players alike. |
So perhaps autorenew should be removed/deprecated/converted in favour of this? |
For me it is confusing not to be able to replace a vehicle with a new vehicle of the same type in the same way as replacing the vehicle with another one of a different type. There is technically no difference except for the type I want to replace the vehicle with. So the similar handling of both cases is IMHO an advantage.
There is a difference in the way the functions work. With "autorenew" all vehicles get replaced with the same type when they get old. For (classic) autoreplace you as the player have to take action. Maybe the functions are mergable so that one can set autorenew (or not) but can override it in the autoreplace-GUI. |
d060ffd
to
1d07a1c
Compare
I maintain that having both autorenew and autoreplace-the-same-vehicle is confusing, and only one or the other should exist |
1d07a1c
to
d91eaca
Compare
Suggestion:
(Note, we did similar in the past, when global settings were turned into vehicle specific settings, like for sg_new_nonstop/new_nonstop or sg_full_load_any) |
This feature is very important, in my opinion. Imagine this scenario, which just happened in a game I'm playing:
Let's say that the 50 trucks model B work very well for me and I need to keep using them: "Model B" still has great reliability and just the cargo capacity that I need. As it is now, I simply have no easy way to renew them because:
Please implement this. |
I am very +1 to the suggestion frosch made in #7729 (comment) And also to Aro's point that having both autoreplace and autorenew is just confusing. |
+1. I'm running bus model A for small towns, and bus model B for large cities. However, I don't want to use autorenew feature, because it will work for all my transport including trains - and I prefer to check each train when it gets old if it can use same locomotive or get a more/less powerful, if it should carry more/less cargo etc. |
Autoreplace old to the same model would be beneficial for games with hard economy settings. Besides this, autorenew is buried under expert options and default off, new users are confused why they can't replace old vehicle with same model, which is still available. Of course, if same model is choosen to autoreplace, only "replace if old" option should be possible, to disallow cheats with station rating (eventually additional server setting to allow it). |
d91eaca
to
37409e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the adage "perfection is the enemy of progress" in mind, I'm going to approve this, but with the intent that at some point in the future gestures vaguely autorenew & autoreplace are merged into something with some sort of consistent UI
…eplace window. This breaks OpenTTD#7729 which specifically allows autoreplace of same engine types, and also did not work properly if the engine had been built during the current game session.
This is not what #7525 asks for, but I think it's just as good, or better. Remove the old restriction on autoreplacing vehicles with the same model, but instead add a check so autoreplace with same model only ever occurs when the vehicle is nearing end of life.